Bluetracker

Tracks Blizzard employees across various accounts.


Western clash bracket website layout unclear

EDIT: TL;DR - If the bracket looks messed up to you, do a hard refresh (ctrl-F5 on chrome)

The layout of the bracket of the western clash on the heroes esports website is not ideal. Right now, it looks like this: http://imgur.com/a/Ks6rr

To me that looks very confusing. I really had to think about what each box is, and how the flow of the tournament is.

I'm pretty sure we can do better!


  • Matt MacNeil

    Posted 7 years, 7 months ago (Source)

    Hard refresh fixed the issue.

    Unfortunately, I don't have the cache headers of the original file I got anymore, so that's little use investigating. I can confirm that toolkit.js has changed now (though the changes seem to be mostly minification artifacts, I haven't found anything substantial).

    Regardless, it works \0/

    Ok, thanks. That gives us a good indicator, thanks for the report again!

  • Matt MacNeil

    Posted 7 years, 7 months ago (Source)

    I'm getting a bunch of

    Uncaught DOMException: Failed to execute 'remove' on 'DOMTokenList': The token provided must not be empty.
      at http://us.heroesofthestorm.com/esports/static/js/toolkit.js:26:13875
    

    if I'm on a normalish desktop resultion. If the screen is small enough to trigger re-flowing, I'm getting

    Uncaught TypeError: Cannot read property 'contentContainer' of undefined
      at c (http://us.heroesofthestorm.com/esports/static/js/toolkit.js:27:19240)
      at c (http://us.heroesofthestorm.com/esports/static/js/toolkit.js:27:19301)
      at c (http://us.heroesofthestorm.com/esports/static/js/toolkit.js:27:19301)
      at http://us.heroesofthestorm.com/esports/static/js/toolkit.js:27:19204
      at Array.forEach (native)
      at a (http://us.heroesofthestorm.com/esports/static/js/toolkit.js:27:19184)
      at i (http://us.heroesofthestorm.com/esports/static/js/toolkit.js:27:19888)
      at d (http://us.heroesofthestorm.com/esports/static/js/toolkit.js:27:20177)
      at l (http://us.heroesofthestorm.com/esports/static/js/toolkit.js:27:20110)
    

    Due to the minification and lack of a sourcemap it's tricky to debug further, but it seems fallback detection past "base" doesn't function properly for the small screen error. For the big screen error I still have more debugging to do.

    Out of curiosity, can you hard refresh the page and let me know if it stays? (Ctrl + F5 on chrome)

  • Matt MacNeil

    Posted 7 years, 7 months ago (Source)

    Not to distract from the issue, but I just wanted to express my gratitude for everything you do in the esports scene. Thanks for facilitating an awesome game and great entertainment! :)

    ♥ Just trying to make good stuff for people to watch.

  • Matt MacNeil

    Posted 7 years, 7 months ago (Source)

    1920 x 1200

    The problem is probably in the js though, I'm getting a ton of errors. I'll let you know if I can get to the bottom of this.

    Haha ok, please do! Thanks for the quick response.

  • Matt MacNeil

    Posted 7 years, 7 months ago (Source)

    Can you let me know what resolution you're viewing this in please?




Tweet