No plans to implement storing the URLs on Out of Cards or running the request from our servers. If we were going to automate that, we'd get proper API authorization off HSR and bake it into the site. I talked about it a bit elsewhere and really don't want to bake more reliance on third parties into the site. There ends up being silly data laws that I really don't want to deal with. By people submitting stuff manually, you're consenting to us storing your collections and I don't need to put up any disclaimers.
Definitely not going away any time soon! Estimates from various orgs so far give us as long as 18 months to 2 years of being cautious, though its tough to say when house lockdowns will end. I'm of the opinion things will start to open up again towards the end of the year but it'll still be a "only go out if you really must, absolutely no large social gatherings allowed" sort of deal. I'm sure my opinion on that will change in a few weeks as we get more information.
We really need a vaccine to start the road to recovery. Getting that rolling will let us be more confident about opening stuff up. Everyone just needs to do their part and stay away from others as much as possible. Less transmission, better outcomes for those who are sick since they get the care they need.
The whole pandemic has been very interesting to watch, as horrible as that may sound (definitely a better way of putting it). Seeing which governments are even just semi-competent and seeing how different people react is all going to help society going forward.
Would data laws be less of a concern if importing from HSReplay was manual only? That is, you would provide your region and account id, but would have to click a button to sync your OoC collection every time you wanted to update it. I would think consent could be inferred from having to manually click the button each time. Perhaps a disclaimer would still be necessary. Obviously, IANAL.
Also, I couldn't find any documentation for HSReplay's API, is it possible to link accounts with third party sites like this one?
If it was manual only, yeah, clicking a button would be good enough for consent as far as I'm aware.
HSReplay does allow "apps" (sites would be included) to connect, we'd just have to ask them for access. Then we'd implement them as an OAuth2 scope on the site and you could then connect accounts. I'm not saying we won't ever do it, it just isn't something I want to focus on right now which is why the simple workaround was added.
We're playing a little bit of catch-up with today's patch notes, including changes that have gone out previously.
New Features
Hearthstone
The collection manager now supports importing cards via JSON.
If you have JSON from your collection, you can now import it.
This is mainly for users of HSReplay that have their collections already synced there.
To get your collection data on HSReplay, use the following string inside of your browser's console (F12) while on their site. This will give you a link that you can click to then copy and paste your data into the form.
Card pages now detail how cards and their golden variants are unlocked.
If you visit your collection page on HSR and hit F12 to open your browser's console. You can follow these steps to figure it out. https://hsreplay.net/collection/mine/
Click on the console's networking tab.
Reload the page.
Using the filter on the network area, search for "account_lo".
Right-click on the URL that pops up and open it in a new tab.
Copy and paste the entire contents of that page into the new field in collection management.
Would it maybe be possible to save some development time and money on your side by just allowing people to import their cards from HSreplay.net?
I would guess you could do some server-side HTML parsing in a cron job and get the whole collection through that. When I go to HSreplay.net and open my collection, I can get a public link to my collection in the top left corner. The link to my collection looks like this: https://hsreplay.net/collection/2/28998325/ . You could also get the full list of my collection as a JSON through this endpoint: https://hsreplay.net/api/v1/collection/?region=2&account_lo=28998325 I am not sure though if those ids match the ids of hearthstone or your DB.
Just a thought... :)
Edit: HSreplay.net, not HSreplay.com
A while back when we had brought HSReplay on as the folks who serve winrate data on the site, we had briefly talked about collection data. The ability for us to integrate into their collections API definitely exists, though details on that were never worked on.
My biggest concern ends up being one of data laws. It becomes another element that has external data where we need to be in compliance with. Thanks to government officials around the world who are creating computer laws who have no real business to do so, it is a very real thing that you get to play with now. I also don't entirely love relying on external services which is why we are going to roll our own importing.
Now, if you wanted a box you could paste your JSON dump into, and we provided details on the format you needed to use (HSR's definitely works for this), it would take about 10 minutes to add to the site and I'll add it now.
Is the desktop client going to be a separate application like the old Innkeeper, or a plugin for HDT? I hope it's the latter unless there are technical reasons why that won't work.
We do want our own desktop application because it will let us do more than only support Hearthstone. With that said though, I would like to make a plugin available for HDT for just the collection side of things so people who use that program and love it would be able to keep stuff in sync
The Death Knight cards don't show up in the collection. I don't see them either filtered by Expansion (KoFT) or Type (Hero). In fact it looks like all Hero cards are missing, not just Death Knights.
I've yet to look into anything for Mac though I do have a MBP so it'll be something we will actually look into, unlike another site that never did. It is very likely that we'll end up with 2 separate applications.
This is definitely the right way to do this if you have a large collection already =D
I'm sorry stuff is manual right now, but I thought the addition of the button and plenty of filters should help everyone input less cards manually. Especially when you consider that commons and rares should be very easily collected for each set, now you only need to really worry about the epics and legendaries being input.
One thing I'd like to add in is the ability to only show cards that you haven't collected yet so there is less junk in the list when adding new cards. Also, sorting the cards in the same order they are in-game would be very beneficial.
Yeah, when I was opening my packs after around 30 I saw a duplicate common card and thought things were broken. Then I did the mental math and was like oh yeah, this really is that good. Then I started to see duplicate rares and still had quite a few packs to go.
I knew this was going to be good for the game, but until I actually cracked open packs and experienced it for myself, I didn't appreciate it as much as I did. Definitely no longer need to order both pre-orders to get a good chunk of your collection done which is awesome.
Thanks for the report and JSON!
A fix is going out now and should be live within 3-5 minutes.
No plans to implement storing the URLs on Out of Cards or running the request from our servers. If we were going to automate that, we'd get proper API authorization off HSR and bake it into the site. I talked about it a bit elsewhere and really don't want to bake more reliance on third parties into the site. There ends up being silly data laws that I really don't want to deal with. By people submitting stuff manually, you're consenting to us storing your collections and I don't need to put up any disclaimers.
Definitely not going away any time soon! Estimates from various orgs so far give us as long as 18 months to 2 years of being cautious, though its tough to say when house lockdowns will end. I'm of the opinion things will start to open up again towards the end of the year but it'll still be a "only go out if you really must, absolutely no large social gatherings allowed" sort of deal. I'm sure my opinion on that will change in a few weeks as we get more information.
We really need a vaccine to start the road to recovery. Getting that rolling will let us be more confident about opening stuff up. Everyone just needs to do their part and stay away from others as much as possible. Less transmission, better outcomes for those who are sick since they get the care they need.
The whole pandemic has been very interesting to watch, as horrible as that may sound (definitely a better way of putting it). Seeing which governments are even just semi-competent and seeing how different people react is all going to help society going forward.
Please see our changelog for more details.
https://outof.cards/forums/out-of-cards/site-updates/3666-out-of-cards-changelog-2020-04-08
Locking this thread and moving it to the proper forum. Please use the site feedback forums for questions like this.
Eerie Ultimatum = YAAAAAASSSSS
If it was manual only, yeah, clicking a button would be good enough for consent as far as I'm aware.
HSReplay does allow "apps" (sites would be included) to connect, we'd just have to ask them for access. Then we'd implement them as an OAuth2 scope on the site and you could then connect accounts. I'm not saying we won't ever do it, it just isn't something I want to focus on right now which is why the simple workaround was added.
We're playing a little bit of catch-up with today's patch notes, including changes that have gone out previously.
New Features
Hearthstone
- The collection manager now supports importing cards via JSON.
- If you have JSON from your collection, you can now import it.
- This is mainly for users of HSReplay that have their collections already synced there.
- To get your collection data on HSReplay, use the following string inside of your browser's console (F12) while on their site. This will give you a link that you can click to then copy and paste your data into the form.
- Card pages now detail how cards and their golden variants are unlocked.
- Mainly for adventures and basic cards.
- We'll use this for other stuff too later on.
`https://hsreplay.net/api/v1/collection/?account_lo=${_userdata["user"]["blizzard_accounts"][0]["account_lo"]}&format=json®ion=${_userdata["user"]["blizzard_accounts"][0]["region"]}`;Changes
Hearthstone
Bug Fixes
Hearthstone
General
Doesn't sound intentional. They'd get a lot of shit from the community if that was a design decision.
At least you ended up with a golden legendary, lol.
Alternate, easier way.
- Open your console (F12)
- Input the following into it. (This will show you a link in the console you can then click)
- Note that if you use multiple region collections on HSR, this gets whatever the first one is in their data.
`https://hsreplay.net/api/v1/collection/?account_lo=${_userdata["user"]["blizzard_accounts"][0]["account_lo"]}&format=json®ion=${_userdata["user"]["blizzard_accounts"][0]["region"]}`;If you visit your collection page on HSR and hit F12 to open your browser's console. You can follow these steps to figure it out.
https://hsreplay.net/collection/mine/
This will definitely make our end of year review!
Got an update deployed out. The third tab on the collection page will allow you to import via JSON input provided from HSReplay.net.
My guesses
A while back when we had brought HSReplay on as the folks who serve winrate data on the site, we had briefly talked about collection data. The ability for us to integrate into their collections API definitely exists, though details on that were never worked on.
My biggest concern ends up being one of data laws. It becomes another element that has external data where we need to be in compliance with. Thanks to government officials around the world who are creating computer laws who have no real business to do so, it is a very real thing that you get to play with now. I also don't entirely love relying on external services which is why we are going to roll our own importing.
Now, if you wanted a box you could paste your JSON dump into, and we provided details on the format you needed to use (HSR's definitely works for this), it would take about 10 minutes to add to the site and I'll add it now.
We do want our own desktop application because it will let us do more than only support Hearthstone. With that said though, I would like to make a plugin available for HDT for just the collection side of things so people who use that program and love it would be able to keep stuff in sync
A fix is currently being deployed to make hero cards display correctly in the collection manager.
Looking into this, thanks
I've yet to look into anything for Mac though I do have a MBP so it'll be something we will actually look into, unlike another site that never did. It is very likely that we'll end up with 2 separate applications.
This is definitely the right way to do this if you have a large collection already =D
I'm sorry stuff is manual right now, but I thought the addition of the button and plenty of filters should help everyone input less cards manually. Especially when you consider that commons and rares should be very easily collected for each set, now you only need to really worry about the epics and legendaries being input.
One thing I'd like to add in is the ability to only show cards that you haven't collected yet so there is less junk in the list when adding new cards. Also, sorting the cards in the same order they are in-game would be very beneficial.
Yeah, when I was opening my packs after around 30 I saw a duplicate common card and thought things were broken. Then I did the mental math and was like oh yeah, this really is that good. Then I started to see duplicate rares and still had quite a few packs to go.
I knew this was going to be good for the game, but until I actually cracked open packs and experienced it for myself, I didn't appreciate it as much as I did. Definitely no longer need to order both pre-orders to get a good chunk of your collection done which is awesome.