Currently, we don't record anything over 2 for automatically imported collections. We also don't process card removals automatically through JSON.
Did you ever have 2 Underlight rods or manually edit it to be that way before?
What's the problem with simply setting the collection values to the values in the JSON dump instead of adding them?
There's no problem. We're just not being destructive with the JSON because it isn't something we're generating. I don't think it is too crazy to assume in the majority of cases people aren't going to import a collection until after they've decided to nuke a bunch of cards.
The whole thing won't matter much though once we have our own way of importing from the Hearthstone client.
A major problem is that for any non-legendary you have one of in your collection, it will say you have two of them because the only thing it does is prevent it from going up past the maximum of two. For example, I just did another import, and although I never got a second copy of Embiggen since the last time, it now says I have two. I also just dusted a whole bunch of cards that aren't used much.
The way it is now, the JSON import feature is next to useless except for the initial import, and then you have to manually adjust it for any changes to your collection, or if you use the JSON import again, you'll have to fix it, like I'm going to have to. I think the HSReplay collection can be assumed to be an accurate reflection of your HS collection, and I really think treating it as authoritative would solve more problems than it causes. If you still don't want to be destructive, you could do something like
if (newValue > oldValue) { oldValue = newValue; }
I don't know what kind of performance hit that would entail doing it for every entry, but probably not much more than what is currently there to prevent the values from going up past the maximum, and I don't think you would need both.
Edit: I've found some cards it says I have three of, such as Power of Creation.
2nd Edit: I think it might not be picking up some Ashes of Outland cards. I had to manually add a few after doing the import.
I was going to report this in the other thread, but it looks like the importer adds the values rather than replaces them. I had manually entered my collection before, then after I did the import, it's saying I have 4 of every card I have 2 of, and 2 of every card I have 1 of.
But probably more importantly, none of the changes I make seem to stick anymore. It tells me it saved successfully, but when I refresh, it's showing the old values again. That happens if I use the importer, or manually change cards.
Would data laws be less of a concern if importing from HSReplay was manual only? That is, you would provide your region and account id, but would have to click a button to sync your OoC collection every time you wanted to update it. I would think consent could be inferred from having to manually click the button each time. Perhaps a disclaimer would still be necessary. Obviously, IANAL.
Also, I couldn't find any documentation for HSReplay's API, is it possible to link accounts with third party sites like this one?
Is the desktop client going to be a separate application like the old Innkeeper, or a plugin for HDT? I hope it's the latter unless there are technical reasons why that won't work.
Your common card is still marked as collected, so you have the same chance of getting it as any other common. If you had never opened your last common, you would get the last common, and probably 3 others you already have.
I've been playing since late 2018, and have never touched ranked. I only do casual for dailies, the solo stuff, and arena. This might make me forget about arena and start trying to rank. I'd been planning to start ranking eventually, this could accelerate that.
I've read there's an option to skip from rank 50 to 25, I don't remember hitting it, but I must have because I'm rank 25.
I'm not sure if this would slow you down a little bit at first for getting epics and legendaries. If you get any duplicate commons or rares, you can save the dust you get towards crafting an epic or legendary you want, but after this goes live you can only do that with a common or rare you don't want, until you have them all.
Or perhaps duplicate protection on epics makes up for it.
If I'm remembering correctly, people would advise that you don't disenchant a bad legendary to ensure you don't get it again. I guess it would be nearly impossible to take advantage of such a loophole with legendary cards.
Yes, it sounds like from that quote, that if you have all rares for example and you dust both copies of one that gets nerfed, you still have all the rares for the purposes of duplicate protection, and you won't have any better chance of getting that card than any other rare you have.
I guess they're announcing the new year and first expansion at the same time this year. Looks like RoS was announced March 14, so that would be pretty close to the usual timing between announcement and release.
Maybe something got messed on my account then. Ctrl+f5 didn't work. I didn't expect it to since I've had this problem since Saturday, and have closed the browser multiple times since then. I even tried deleting all OOC cookies and that didn't help either.
I'm using Chrome on Windows 10 1903. If it's only me, maybe an admin can reset my votes for that card?
I would've replied sooner, but I wasn't seeing a notification that anybody replied to my thread.
It looks like the form is coming back with a 500 error when I try to submit a vote for Arena or Overall on Shu'ma. Standard and Wild works. I mentioned this in the discussion thread, but it may have gotten lost with all the other posts.
I'm able to rate every card except this one. On the card page, if I try to submit a rating for overall or arena, the form throws a 500 error, according to Chrome dev tools. If I leave those blank and just vote for standard and wild, it works fine. It doesn't work on the expansion guide or this thread either. I don't know if anybody with the power to fix it will see this, but I thought I should mention it.
The only reason I ever opened a tournament stream was for twitch drops. And I never actually watched the stream.
Since when are tokens not minions?
A major problem is that for any non-legendary you have one of in your collection, it will say you have two of them because the only thing it does is prevent it from going up past the maximum of two. For example, I just did another import, and although I never got a second copy of Embiggen since the last time, it now says I have two. I also just dusted a whole bunch of cards that aren't used much.
The way it is now, the JSON import feature is next to useless except for the initial import, and then you have to manually adjust it for any changes to your collection, or if you use the JSON import again, you'll have to fix it, like I'm going to have to. I think the HSReplay collection can be assumed to be an accurate reflection of your HS collection, and I really think treating it as authoritative would solve more problems than it causes. If you still don't want to be destructive, you could do something like
if (newValue > oldValue) {oldValue = newValue;
}
I don't know what kind of performance hit that would entail doing it for every entry, but probably not much more than what is currently there to prevent the values from going up past the maximum, and I don't think you would need both.
Edit: I've found some cards it says I have three of, such as Power of Creation.
2nd Edit: I think it might not be picking up some Ashes of Outland cards. I had to manually add a few after doing the import.
What's the problem with simply setting the collection values to the values in the JSON dump instead of adding them?
I'm about to click on every Tavern Brawl to find #2. Is it even HS related?
Edit: Nevermind, it became pretty obvious once I started reading the names more carefully.
I was going to report this in the other thread, but it looks like the importer adds the values rather than replaces them. I had manually entered my collection before, then after I did the import, it's saying I have 4 of every card I have 2 of, and 2 of every card I have 1 of.
But probably more importantly, none of the changes I make seem to stick anymore. It tells me it saved successfully, but when I refresh, it's showing the old values again. That happens if I use the importer, or manually change cards.
P.S. Why does it say there are 306 Basic cards?
Would data laws be less of a concern if importing from HSReplay was manual only? That is, you would provide your region and account id, but would have to click a button to sync your OoC collection every time you wanted to update it. I would think consent could be inferred from having to manually click the button each time. Perhaps a disclaimer would still be necessary. Obviously, IANAL.
Also, I couldn't find any documentation for HSReplay's API, is it possible to link accounts with third party sites like this one?
Is the desktop client going to be a separate application like the old Innkeeper, or a plugin for HDT? I hope it's the latter unless there are technical reasons why that won't work.
Your common card is still marked as collected, so you have the same chance of getting it as any other common. If you had never opened your last common, you would get the last common, and probably 3 others you already have.
If you target a minion without a tag, will it just hit that minion, or all minions without tags?
You may have trouble putting this in a priest deck.
I've been playing since late 2018, and have never touched ranked. I only do casual for dailies, the solo stuff, and arena. This might make me forget about arena and start trying to rank. I'd been planning to start ranking eventually, this could accelerate that.
I've read there's an option to skip from rank 50 to 25, I don't remember hitting it, but I must have because I'm rank 25.
I'm not sure if this would slow you down a little bit at first for getting epics and legendaries. If you get any duplicate commons or rares, you can save the dust you get towards crafting an epic or legendary you want, but after this goes live you can only do that with a common or rare you don't want, until you have them all.
Or perhaps duplicate protection on epics makes up for it.
If I'm remembering correctly, people would advise that you don't disenchant a bad legendary to ensure you don't get it again. I guess it would be nearly impossible to take advantage of such a loophole with legendary cards.
Yes, it sounds like from that quote, that if you have all rares for example and you dust both copies of one that gets nerfed, you still have all the rares for the purposes of duplicate protection, and you won't have any better chance of getting that card than any other rare you have.
I guess they're announcing the new year and first expansion at the same time this year. Looks like RoS was announced March 14, so that would be pretty close to the usual timing between announcement and release.
Anybody know if solo bosses are immune to this or anything? I have a Lich King to kill a bunch of times.
Maybe something got messed on my account then. Ctrl+f5 didn't work. I didn't expect it to since I've had this problem since Saturday, and have closed the browser multiple times since then. I even tried deleting all OOC cookies and that didn't help either.
I'm using Chrome on Windows 10 1903. If it's only me, maybe an admin can reset my votes for that card?
I would've replied sooner, but I wasn't seeing a notification that anybody replied to my thread.
It looks like the form is coming back with a 500 error when I try to submit a vote for Arena or Overall on Shu'ma. Standard and Wild works. I mentioned this in the discussion thread, but it may have gotten lost with all the other posts.
I'm able to rate every card except this one. On the card page, if I try to submit a rating for overall or arena, the form throws a 500 error, according to Chrome dev tools. If I leave those blank and just vote for standard and wild, it works fine. It doesn't work on the expansion guide or this thread either. I don't know if anybody with the power to fix it will see this, but I thought I should mention it.
I predict it fixes itself on the 10th.